feat(browser): provide project reference in ToMatchScreenshotResolvePath#10138
Open
macarie wants to merge 3 commits intovitest-dev:mainfrom
Open
feat(browser): provide project reference in ToMatchScreenshotResolvePath#10138macarie wants to merge 3 commits intovitest-dev:mainfrom
ToMatchScreenshotResolvePath#10138macarie wants to merge 3 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
macarie
commented
Apr 13, 2026
Comment on lines
+481
to
+486
| /** | ||
| * The project's fully resolved {@link https://vitest.dev/config/|configuration}. | ||
| * | ||
| * @experimental | ||
| */ | ||
| config: ResolvedConfig |
Member
Author
There was a problem hiding this comment.
Not sure if this is the best thing to do or if we should just pick/re-create the instances entry the project is running within 🤔
Member
There was a problem hiding this comment.
I would just pass down project, we already pass it down for global setup
Member
Author
There was a problem hiding this comment.
Yeah, that would be more consistent. Should I keep the @experimental tag?
macarie
changed the title
ToMatchScreenshotResolvePathToMatchScreenshotResolvePath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #10039
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.